-
Notifications
You must be signed in to change notification settings - Fork 14k
Changes a little the description of take in the guide #18273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this phrasing is better, but the first part of the sentence is still too active: |
|
@huonw 👍 |
|
@huonw better ? |
src/doc/guide.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
give away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, return is better :p
|
@steveklabnik better ? |
|
r? |
|
Thanks. Editing is the worst, sorry there was so much churn over such a small change. |
|
@steveklabnik No problem :) If you want a hand on more edits in the doc I'm here :) |
Closes #18218